search

robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
458 stars 20 forks source link

Crash when attempting to open PNG #5

Closed SimplyTheOther closed 6 years ago

SimplyTheOther commented 6 years ago

I opened up Seashore from the Dock and then attempted to open a PNG file through the "File" menu. After selecting the file and pressing "Open", the program crashed and disappeared from the Dock. I attempted to repeat the process, and it crashed again with a different PNG file. It did, however, open a JPEG file in the same directory.

The version of Seashore I have installed is "Version 0.6.3 (20171025)" and I am currently running Mac OS Mojave (10.14) on a 13-inch mid-2012 MacBook Pro.

The "Problem Report for Seashore" is available here: https://pastebin.com/jFZDA7iS

robaho commented 6 years ago

Thank you, I will look into it as soon as I get a chance.

robaho commented 6 years ago

@SimplyTheOther Can you attach one of the PNG's it was crashing with? That would be very helpful. You can PM it to me if you don't want to post publicly.

SimplyTheOther commented 6 years ago

e3_logo_dropshadow floorplanedits Sorry for the wait. It crashes with the first image when attempting to open it through the file menu and when opening it through Finder, while it only crashes for the second image when attempting to open it through Finder (i.e. it opens successfully through the file menu).

The crash log created when trying to open the second through Finder is here: https://pastebin.com/vPNUi1pG

robaho commented 6 years ago

This is fixed in 0.6.4. The ColorSync stuff is REALLY deprecated now, and there is a bug opening the embedded profiles in these files (even though other tools like Preview show there aren't any - maybe because they determine they are corrupt).

Anyway, changing from CMOpenProfile() to CMNewProfile() allows the profile to be scanned - it is empty then, and when that is detected, a new RGB profile is used.