robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
452 stars 20 forks source link

Layer pane/sidebar colouration issue #53

Closed SimplyTheOther closed 5 years ago

SimplyTheOther commented 5 years ago

On my Mac (macOS Mojave 10.14.4 mid-2012 MacBook Pro), Seashore's layer pane background is black in both "light" mode and "dark mode". The old Seashore's wasn't, and I thought it might have been simply an aesthetic choice, but I noticed that your screenshot doesn't have this issue. I think you mentioned before that your computer didn't support dark mode, so that could be the root of it.

Here's a screenshot of Seashore in "light mode": Screen Shot 2019-05-10 at 8 29 32 pm versus the screenshot on the readme:

The layer displays themselves do not appear to be affected - it simply seems to be the colour of the background. For example, with several layers: Screen Shot 2019-05-10 at 8 39 02 pm

Also, if I use my trackpad to scroll up inside the layers sidebar, it shows that there is white below the black. Similarly, if I scroll up, there's white on top of the sidebar. Screen Shot 2019-05-10 at 9 07 31 pm Screen Shot 2019-05-10 at 9 09 01 pm

So yeah, while this does not impact functionality at all, it would be more aesthetically pleasing if it was fixed.

robaho commented 5 years ago

I agree, and am working on fixing. It only happens in Mojave - so hard for me to fix/debug.

robaho commented 5 years ago

@SimplyTheOther maybe you can help me out, if you use the painting tools, do the brushes/pencils appear properly in the 'recents' pane ?

SimplyTheOther commented 5 years ago

I'm not sure what the 'recents' pane is meant to show, but nothing appears for me after drawing with a brush, changing brush sizes and drawing with the new size, changing to pencil and drawing with that, changing brush to wood texture and drawing with it, changing back to pencil and drawing with the wood texture (or a colour from it or something), etc.

I took a video to illustrate this with as many tools as I could use (attached as a zip because apparently videos aren't supported properly):

SeashoreRecents.mp4.zip

robaho commented 5 years ago

@SimplyTheOther thank you for the video. It confirms what I saw previously - not sure what is different on the machine where the original screenshots were taken - but I am in the process of installing a Mojave VM so I should be able to fix it.

robaho commented 5 years ago

fixed in 2.4.3