search

robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
447 stars 20 forks source link

using text with larger fonts near edges causes crash with text tool #61

Closed robaho closed 5 years ago

robaho commented 5 years ago

Thread 0 Crashed: 0 app.seashore 0x0000000103cac1d0 -[TextTool drawOverlay] (in Seashore) (TextTool.m:121) 1 app.seashore 0x0000000103cacf68 -[TextTool preview:] (in Seashore) (TextTool.m:203) 2 app.seashore 0x0000000103cade2a -[TextOptions changeFont:] (in Seashore) (TextOptions.m:86) 3 app.seashore 0x0000000103cea598 -[NSTextViewRedirect changeSpecialFont:] (in Seashore) (NSTextViewRedirect.m:13) 4 com.apple.AppKit 0x00007fff2fcaea43 -[NSApplication(NSResponder) sendAction:to:from:] + 312 5 com.apple.AppKit 0x00007fff2f8cb1ef -[NSFontManager sendAction] + 93 6 com.apple.AppKit 0x00007fff2f8d435a -[NSFontManager modifyFontViaPanel:] + 77

robaho commented 5 years ago

fixed in 2.4.5

The code was not handling the case where the ascent on a large font could make the positioning negative.