search

robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
447 stars 20 forks source link

Enhancement: Non-contiguous paint bucket #84

Closed Joseph-Y closed 4 years ago

Joseph-Y commented 4 years ago

I'd just like to request the feature for the paint bucket to fill non-contiguous pixels.

I checked the Help guide to confirm this is not yet a feature--sorry if I'm missing something.

robaho commented 4 years ago

Hi @Joseph-Y, can you describe a little bit of what you want? There is a "tolerance" setting that controls how big an area is painted. You can also use the 'option' key to flood the entire layer/selection.

But, if I understand your ask correctly, it seems that in the end this would be implemented as "paint all pixels in the layer within a 'tolerance' of the clicked pixel'. Is this what you want ?

Joseph-Y commented 4 years ago

Yes, that's the request! Currently, if you draw a black circle on an empty canvas and then paint bucket the white pixels outside the circle, the white pixels inside the circle don't fill because the pixels aren't contiguous. Thank you for your consideration.

And thank you for this awesome program Robert. I use it daily as a medical student to make and edit diagrams.

On Mon, Nov 11, 2019, 11:03 AM robert engels notifications@github.com wrote:

Hi @Joseph-Y https://github.com/Joseph-Y, can you describe a little bit of what you want? There is a "tolerance" setting that controls how big an area is painted. You can also use the 'option' key to flood the entire layer/selection.

But, if I understand your ask correctly, it seems that in the end this would be implemented as "paint all pixels in the layer within a 'tolerance' of the clicked pixel'. Is this what you want ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robaho/seashore/issues/84?email_source=notifications&email_token=ANOYLCNZLGFNAXKVHMCEXBLQTGT63A5CNFSM4JLO6GEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXZBJI#issuecomment-552571045, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOYLCLWWO3KTMJYL7K5WW3QTGT63ANCNFSM4JLO6GEA .

robaho commented 4 years ago

@Joseph-Y One work-around that may be helpful - at least in the example of the circle - is to use the color select tool to select the circle, then use 'edit -> select inverse', then use the option key = paint bucket to perform a flood fill.

I'm looking into a code change to add an option to the color select tool to 'select all' which would do what you want.

robaho commented 4 years ago

fixed in 2.4.13. I added an options to the 'color select wand', to 'select all regions'. So you can use this, then use the 'flood fill' with the 'bucket tool' to do what you want. This is more versatile than only adding the option to the bucket fill. @Joseph-Y

Joseph-Y commented 4 years ago

Thank you so much again Robert. You rock.

On Tue, Nov 12, 2019, 4:39 PM robert engels notifications@github.com wrote:

fixed in 2.14.13. I added an options to the 'color select wand', to 'select all regions'. So you can use this, then use the 'flood fill' with the 'bucket tool' to do what you want. This is more versatile than only adding the option to the bucket fill. @Joseph-Y https://github.com/Joseph-Y

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robaho/seashore/issues/84?email_source=notifications&email_token=ANOYLCLWSMVAMM6OEXRRBP3QTNEFDA5CNFSM4JLO6GEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4OTXA#issuecomment-553183708, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOYLCNGFMYQJYBNDYPKR6DQTNEFDANCNFSM4JLO6GEA .

robaho commented 4 years ago

@Joseph-Y should be available on the App Store now - let me know how it works.

Joseph-Y commented 4 years ago

Works beautifully. Thanks again. Is there a tip jar where I can buy you a beer?

On Tue, Nov 12, 2019, 6:39 PM robert engels notifications@github.com wrote:

@Joseph-Y https://github.com/Joseph-Y should be available on the App Store now - let me know how it works.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robaho/seashore/issues/84?email_source=notifications&email_token=ANOYLCK5VT5KLTRPDBAG3WDQTNSGFA5CNFSM4JLO6GEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4VOLA#issuecomment-553211692, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOYLCM7LG76CP7LDC7HZ5DQTNSGFANCNFSM4JLO6GEA .

robaho commented 4 years ago

@Joseph-Y just leave a good review and rating on the app store :)