search

robashaw / libecpint

A C++ library for the efficient evaluation of integrals over effective core potentials.
MIT License
28 stars 15 forks source link

Added a BUILD_BYPRODUCT to ImportPugiXML.cmake for compatibility with Ninja #20

Closed thomas-dresselhaus closed 3 years ago

thomas-dresselhaus commented 3 years ago

I'm using the Ninja generator/build system (i.e. one types ninja instead of make). Unfortunately, this leads to an issue with ExternalProject_Add. (I believe this actually is an issue of CMake's Ninja generator.)

The line I added here just tells CMake very explicitly that the library file is generated from this external project. For the usual Makefile generator, CMake automatically figures that out correctly, for Ninja it has to be stated explicitly.

This change should not affect the Makefile system at all.

I'd be glad if you would merge that in.

robashaw commented 3 years ago

All merged, thanks for the contribution.