robashaw / libecpint

A C++ library for the efficient evaluation of integrals over effective core potentials.
MIT License
28 stars 15 forks source link

JOSS review changes #38

Closed robashaw closed 3 years ago

robashaw commented 3 years ago

This addresses issues #34, #35, #36, and #37 created as part of the JOSS review process. It contains the JOSS paper, along with the following changes:

The python bindings mentioned in issue #8 are being handled separately.

This branch will be merged at the end of the review process.

codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (035a3de) into master (d53a409) will increase coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   89.71%   89.80%   +0.09%     
==========================================
  Files          19       19              
  Lines        1954     1952       -2     
==========================================
  Hits         1753     1753              
+ Misses        201      199       -2     
Impacted Files Coverage Δ
include/libecpint/ecpint.hpp 100.00% <ø> (ø)
src/lib/api.cpp 81.27% <0.00%> (+0.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d53a409...035a3de. Read the comment docs.

felipeZ commented 3 years ago

Great job!