search

robashaw / libecpint

A C++ library for the efficient evaluation of integrals over effective core potentials.
MIT License
28 stars 15 forks source link

cerf instead of Faddeeva #55

Closed loriab closed 2 years ago

loriab commented 2 years ago

This is roughly what I was thinking of for #53 . See what you think. (PR includes #52 but I can rebase those out later.)

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (054c3fa) into master (5542ea0) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          19       19           
  Lines        1953     1953           
=======================================
  Hits         1754     1754           
  Misses        199      199
Impacted Files Coverage Δ
src/lib/ecpint.cpp 100.00% <ø> (ø)
src/lib/radial_gen.cpp 81.46% <ø> (ø)
src/lib/radial_quad.cpp 83.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5542ea0...054c3fa. Read the comment docs.

robashaw commented 2 years ago

All good, thanks for the changes.