search

robatwilliams / es-compat

*** DEPRECATED*** Check JavaScript code compatibility with target runtime environments
MIT License
66 stars 13 forks source link

check-es-compat: Disallowed Eslint inline config comments to work with unminified code. #102

Closed brabeji closed 7 months ago

brabeji commented 7 months ago

Fixes #100

robatwilliams commented 7 months ago

I've now removed the Node 14 build check gate, as the actual build configuration was removed previously.

robatwilliams commented 7 months ago

This change does remove the option for CLI users to disable this plugin. The reporter of https://github.com/robatwilliams/es-compat/issues/47 was doing this as a workaround (last sentence of the issue description). But they weren't using CLI.

I think this is fine. From a CLI tool perspective it shouldn't even be visible that ESLint is used under the hood.

brabeji commented 7 months ago

From a CLI tool perspective it shouldn't even be visible that ESLint is used under the hood.

agreed

robatwilliams commented 7 months ago

Released in https://github.com/robatwilliams/es-compat/releases/tag/v3.2.1