Closed brettz9 closed 2 years ago
Thanks for this, looks good.
ESLint 7 was only released last Friday, I think we should wait a few patch/minor releases for any teething problems to be ironed out.
I'll take a look at that missing coverage sometime. I already checked the coverage when I created this (hence it already being in the .gitignore
).
ESLint is now to 7.5.0, so do you want to take a look now? I've added a few more updates per the latest stable versions available.
(Note that ci (8.x)
is still showing in this PR, though this PR drops checking of 8 in favor of maintained Node versions.)
Apologies that I didn't accept this in good time before it became too stale. I have been doing other things in life.
I've done most of those things myself now. And updated the contributing page to try and help avoid wasting future time by other potential contributors.
Thanks
Wanted to confirm things were working as expected in latest eslint and found some available updates as well.
.editorconfig
to enforce 2sp. indent during editing.ncurc.js
to avoid auto-updating peerDeps in eslint plugin (used bynpm-check-updates
)lint
script tocheck-es-compat
andeslint-plugin-ecmascript-compat
In adding coverage, I note that there is one ternary "else" condition not covered, but I didn't dive into the code to figure that one out in case you might want to take a look.