Closed robatwilliams closed 6 months ago
Runs into problem https://github.com/mysticatea/eslint-plugin-node/issues/349
Could disable that rule, and rely on CI unit tests to catch e.g. Node 14 issues. But currently that doesn't cover the check-es-compat
utility.
Disable the rule, and use es-compat itself to check compatibility of its own source code? (!) But that would be disconnected from package.json:engines
Need to switch to https://github.com/eslint-community/eslint-plugin-n because the author (same one as eslint-plugin-es) has also abandoned his node plugin
Blocked on Jest ESM support - https://jestjs.io/docs/ecmascript-modules
to do as part of this eventually:
mjs
extension and references to ittype:module
in package.jsonsimport/newline-after-import
instead of custom spacing lint ruleplugin:n/recommended-module
Also see this about importing browser compat data https://github.com/mdn/browser-compat-data/releases/tag/v5.0.0
Update the code of the plugin itself to use
import
andexport
rather thanrequire
andmodule.exports
.Update the lint rules in eslintrc to require this style, and prohibit CommonJS style.