robatwilliams / es-compat

*** DEPRECATED*** Check JavaScript code compatibility with target runtime environments
MIT License
66 stars 13 forks source link

Flat config support / ESLint 9 #92

Open brettz9 opened 8 months ago

brettz9 commented 8 months ago

Hi,

As of ESLint 8, there is now a new format for ESLint config files which requires that plugins follow a specific format. In ESLint 9, this format will be the only one available by default (and other API changes have occurred in ESLint 9 that may affect this plugin).

Info:

  1. https://eslint.org/docs/latest/use/configure/configuration-files-new
  2. https://eslint.org/blog/2022/08/new-config-system-part-1/
  3. https://eslint.org/blog/2022/08/new-config-system-part-2/
  4. https://eslint.org/docs/latest/use/configure/migration-guide

Thanks!

robatwilliams commented 8 months ago

Thanks.

Initial rough view of changes required:

Impact:

Would be good to remain under test for both v8 and v9 for a while, unless not it's too much work.

benasher44 commented 5 months ago

The plugin also throws an error if used with FlatConfig compatibility helpers. Even if it doesn't natively support FlatConfig, it would great to fix that in the interim.

robatwilliams commented 5 months ago

I'm afraid I have barely any time spare for this project at the moment, and neither am I using this nor ESLint 9.

I see 9 was released 3 weeks ago although of course ideally I would have tested against the beta. But now more and more people will be upgrading.

If someone could post some detail about the problem with the compatibility helpers, it might help me judge whether it's something I could spot-fix when I have half an hour spare.

benasher44 commented 5 months ago

Actually I take it back. I can't reproduce the crash anymore. If I see it again, I'll come back with a reproduction. Apologies!