search

robb / Cartography

A declarative Auto Layout DSL for Swift :iphone::triangular_ruler:
Other
7.35k stars 525 forks source link

Light refactorings #252

Closed adamnemecek closed 6 years ago

orta commented 7 years ago

This is quite a lot of code to just drop without any description, can you please write up a summary of your changes and why?

adamnemecek commented 7 years ago

It's all refactoring of the current code? Why? I believe that my refactorings increase clarity or reduce source code size.

orta commented 7 years ago

It currently exists in a vacuum, I'm not really done any Swift in a year, and have never used this library -yet I am the maintainer. I would struggle to judge whether to merge and take over your changes without some kind of explanation?

orta commented 6 years ago

Thanks for the PR - given the number of of conflicted files and lack of response in a while - I'm going to close this 👍