Add Safe Area Layout support

robb / Cartography

A declarative Auto Layout DSL for Swift :iphone::triangular_ruler:

Other

7.35k stars 525 forks source link

Add Safe Area Layout support #267

Closed yysskk closed 6 years ago

yysskk commented 6 years ago

iOS11 added the concept of Safe Area. It would be nice to be able to use it. I supported to it using safeAreaLayoutGuide, but how about you?

orta commented 6 years ago

This looks great - as this is a library used by a lot of people and we don't want to break features in the future, can you add some tests to cover your changes 👍

yysskk commented 6 years ago

@orta Thanks, review! I am glad to accept you. I added tests, so please take a look.

orta commented 6 years ago

These tests are 💯 - amazing

orta commented 6 years ago

Shipped as 2.1.0

mathieutozer commented 6 years ago

Did this change get reverted? I don't see it in the latest release via Cocoapods!

inamiy commented 6 years ago

API changed in https://github.com/robb/Cartography/pull/269 for ver 3.x.