search

robb / Cartography

A declarative Auto Layout DSL for Swift :iphone::triangular_ruler:
Other
7.34k stars 526 forks source link

Swift 5.0 support. #308

Closed netizen01 closed 5 years ago

netizen01 commented 5 years ago

Pretty straightforward update here.

New PodSpec format where you declare multiple swift versions is supported. Removed the warnings about redundant "public" modifiers. Upgraded the project settings for Xcode 10.2. (no impact on the actual pod code)

orta commented 5 years ago

Cool, might need to wait on Travis supporting Xcode 10.2 from the looks of it though

jwietelmann commented 5 years ago

@netizen01 Looks like you should be able to get CI to pass now with this:

https://docs.travis-ci.com/user/reference/osx/#xcode-102

Xcode 10.2.1 is available by adding osx_image: xcode10.2 to your .travis.yml.

jwietelmann commented 5 years ago

@orta @netizen01 Actually, I just went ahead and forked the PR, made the little Travis change, and submitted it as a new PR, and the build passed: https://github.com/robb/Cartography/pull/310

kajensen commented 5 years ago

This is broken with latest stable cocoapod version 1.6.1. (Seems to rely on 1.7 beta).

Specifically s.swift_versions = ["4.2","5.0"] should be s.swift_version = "5.0"