search

robb / Cartography

A declarative Auto Layout DSL for Swift :iphone::triangular_ruler:
Other
7.35k stars 524 forks source link

Xcode11 build issue fix #314

Open luko-g opened 4 years ago

luko-g commented 4 years ago

Because constrain function is defined in CommonUISDK looks like XCode11 cannot compile Cartography pod anymore. Renaming constrain functions to cg_constrain seems to fix the problem

closes: https://github.com/robb/Cartography/issues/313

orta commented 4 years ago

This is a pretty drastic API change - are there any other ideas to make this work?

luko-g commented 4 years ago

@orta I guess you can leave it as is and just expect everyone to use namespaces. Cartography.constrain

orta commented 4 years ago

I think this is probably better, yeah 👍

Any chance you can update docs and then this is good to go?

SudeepKS88 commented 4 years ago

Any update on this? Can we push this up if everything looks fine?

orta commented 4 years ago

This changes the API in a way that makes all the README's examples not work - happy to have you fix that in a PR with these changes also?

orta commented 2 years ago

Happy to have someone re-implement the PR with the feedback rather than wait