Fix low contrast and non-visible colors

robb0wen / synthwave-vscode

Synthwave inspired colour theme for VS Code 🌅🕶

MIT License

5.16k stars 1.18k forks source link

Fix low contrast and non-visible colors #172

Closed moxwel closed 4 years ago

moxwel commented 4 years ago

This fixes some details related to the low contrast of comments, related to #124

Before / After

And a little bug in the integrated terminal: the selection was no-visible, now is visible.

Before / After

moxwel commented 4 years ago

Also, a little fix to the background color when grouping editors. Now it have more contrast too:

Before

After

moxwel commented 4 years ago

The diffEditor colors now have more contrast.

Before / After

moxwel commented 4 years ago

Command palette active selection now are more visible

Before / After

aasutossh commented 4 years ago

Why isn't this getting merged?

moxwel commented 4 years ago

Why isn't this getting merged?

@aasutossh It seems we have to wait... @robb0wen decides if this PR will be merged (or not).

aasutossh commented 4 years ago

How do I use your version of the theme?

moxwel commented 4 years ago

How do I use your version of the theme?

@aasutossh It's a little tricky, but you can copy/paste the edited synthwave-color-theme.json in the folder where you have the theme installed on VSCode.

On Windows, the file is located at %USERPROFILE%\.vscode\extensions\robbowen.synthwave-vscode-0.1.6\themes.

aasutossh commented 4 years ago

Gonna use it until it gets merged.

dominiquediotte commented 4 years ago

I completely approve the higher contrast element. Currently, it's hard to see things.

robb0wen commented 4 years ago

Apologies for the delay on merging this. Combination of being very busy with my day-job and Covid lockdown. Anyhow, this is a fantastic help, thanks.

moxwel commented 4 years ago

No problem! And thank you 😊

aasutossh commented 4 years ago

Finally. Yay yay yay!!! <3