Open chris-crowson opened 4 years ago
The theme's primary colour for supported languages is the dark purple so the update was intended to make python more consistent. It's hard to modify support because people who have been using incomplete / partially supported languages will have gotten used to the unstyled parts (the greyish text, in this case).
I guess I'll wait for more feedback and maybe update it again.
That’s understandable, and the conclusion I came to after talking to a few friends who also use the theme with other languages. I was able to resolve for me personally for the time being, by reverting your recent commits on my local files.
Just chiming in here, I also dislike the new color theme as a Javascript dev. My eyes have a hard time visually parsing keys in objects now. I'm sure I'll get used to it in time, but here's a pic for example. The keys used to be purple like variable names before the last update.
As you can see keys are the same color as integers, and nested object's keys are the same color as the parent object's. The blue is extremely overwhelming. Great work on the theme though, I have used it for over a year now without ever changing :)
@Raymond-Cox hmm that one is unintentional. I think one of the theme keys must be bleeding through from somewhere else. I'll get it fixed.
Update: It's the semantic theming update that's causing it
I've been having the same issue after the update. It's really hard to differentiate between all the purple.
Before:
After:
Had a similar issue with Go.
Can easily fix in VS Code by dropping the version in the extensions drop down. I went back to v1.6 and it looks normal again :)
This was my concern to be honest.
What you might see as normal isn't necessarily how the theme was designed. The purple was always the base colour and the white seen on go and python was basically unstyled.
I've had a lot of issues and emails about fixing the unstyled elements so I've been trying to bring more languages in line with the original design. At the same time, I understand that many people will have gotten used to however their language of choice was working until now. It's tricky.
I'll give this more thought. I'd like for there to be a consistent design across languages but I don't want to alienate people
I don't know if it's a matter of somebody getting "used to however their language of choice was working until now". I tried to use the new changes but it wasn't working for me, I honestly just prefer the un-styled, minimalistic look.
Wondering if the base colour could just be something configurable?
I also find it easier to read code on the un-styled version in python
My two cents: I love the purple in the screenshots and think it's much better than the 'unstyled' versions and feel like that's the entire point of this theme -- bold, bright, in-your-face colors everywhere. If that doesn't work for you, maybe this isn't the best theme for your needs.
I would fully support customization of the various colors, but am unsure of the technical hurdles around that.
I've worked with Python files with this theme, and I remember this colors way back 0.1.5.
I think something has to do with the Python Extension, because I remember a time when all the text was grey, until I setted up Python for VSCode.
nah, my php looks nothing alike either.
it only looks right with neon dreams enabled, which tbh i was gonna do anyway.
i just wish the neon dreams settings were in an easier to edit file because i always add more glows an tweaked the colours with the og two extension version.
after picking up colours in the neon dreams js file im actually really confused at why the "every day" colours are actually intentionally that ugly, and not the same as with neon dreams enabled, just without the glow. like, its two completely different themes here lmao. in my mind, neon dreams on and off should look almost exactly the same, just one has text-shadow glows and one would not.
After 2 months of the new theme, I've come to like it. I guess it just takes some time to get used to.
I have another problem and I think this is the right place to mention it.
Some parts are highlighted differently after the editor is done loading.
Example:
when I open the editor and this after a few seconds:
I have the same problem with neon dreams:
I want the syntax highlighting to be always the same as when the editor isn't fully loaded, for example I prefer the glowing
self
. How can I do that ?
Before the most recent update, Python code with this theme was perfect. There was glow, some purple, some yellow (see pic 1). After this recent update, the purple is overwhelming (see pic 2).
![VSCode2](https://user-images.githubusercontent.com/48335013/90821470-96eb6f00-e2f8-11ea-9c36-bf83814278fd.jpg)