search

robb0wen / synthwave-vscode

Synthwave inspired colour theme for VS Code 🌅🕶
MIT License
5.15k stars 1.18k forks source link

VSCode Feature Request to support the "glow" #241

Open eljeffeg opened 2 years ago

eljeffeg commented 2 years ago

You mention in the readme "Because enabling the glow modifies core files, VS code will interpret this as the core being 'corrupted' and you may see an error message on restarting your editor. You can safely dismiss this message, or remove it entirely with the Fix VSCode Checksums extension."

Is there an issue (feature request) over at https://github.com/microsoft/vscode we can support / encourage to allow this type of extension to work without having to modify core files and "corrupt" Visual Studio code? I love this theme, but I always feel uneasy when updating and going through this process. It seems hacky and I would hope MS could build out their extension capability to make it not so.

eljeffeg commented 2 years ago

Or better yet, submit a PR to VSC to add the option that would allow theme based text effects.

robb0wen commented 2 years ago

At the time that I made the theme I found a few discussions about supporting CSS text-shadow in themes, but I believe it was declined. If I get chance I might take a look at the source and see if I can create a PR for it.

jrehwaldt commented 2 years ago

FWIW https://github.com/microsoft/vscode/issues/58301 seems to be the issue to vote for and subscribe to.

eljeffeg commented 2 years ago

@robb0wen I wonder if the new CSS formatter in version 1.66 may help. https://code.visualstudio.com/updates/v1_66#_css-formatter