Closed GeorgiNiagulov closed 1 year ago
+1 Glow no longer working after update
Version: 1.74.0
Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91
Date: 2022-12-05T16:43:37.594Z (2 days ago)
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 22.1.0
Sandboxed: No
yes. I also have the same problem when vscode update to v1.74
confirm. It was working with previous version but not v1.74. I tried to reinstall follow the steps but can't help
confirm. not working.
I'm Using VScode v1.74 and the glow is not working
It looks like the ".vscode-tokens-styles" element may contain some default value instead of being empty, which triggers the theme to initialize too early.
A temporary workaround might be like: [VSCode Dir]\resources\app\out\vs\code\electron-sandbox\workbench\neondreams.js:164
// does it have content ?
const tokenStyles = document.querySelector('.vscode-tokens-styles').innerText
&& document.querySelector('.vscode-tokens-styles').innerText !== ''
&& document.querySelector('.vscode-tokens-styles').innerText.includes(".mtk7");
You may also need to restart the vscode app to make the modification take effect.
It looks like the ".vscode-tokens-styles" element may contain some default value instead of being empty, which triggers the theme to initialize too early.
A temporary workaround might be like: [VSCode Dir]\resources\app\out\vs\code\electron-sandbox\workbench\neondreams.js:164
// does it have content ? const tokenStyles = document.querySelector('.vscode-tokens-styles').innerText && document.querySelector('.vscode-tokens-styles').innerText !== '' && document.querySelector('.vscode-tokens-styles').innerText.includes(".mtk7");
You may also need to restart the vscode app to make the modification take effect.
It works! Thanks!
It looks like the ".vscode-tokens-styles" element may contain some default value instead of being empty, which triggers the theme to initialize too early.
A temporary workaround might be like: [VSCode Dir]\resources\app\out\vs\code\electron-sandbox\workbench\neondreams.js:164
// does it have content ? const tokenStyles = document.querySelector('.vscode-tokens-styles').innerText && document.querySelector('.vscode-tokens-styles').innerText !== '' && document.querySelector('.vscode-tokens-styles').innerText.includes(".mtk7");
You may also need to restart the vscode app to make the modification take effect.
It works, thanks ! And for those who ask about Ubuntu, the path is ~/.vscode/extensions/robbowen.synthwave-vscode-0.1.14/src/js/theme_template.js
It looks like the ".vscode-tokens-styles" element may contain some default value instead of being empty, which triggers the theme to initialize too early.
A temporary workaround might be like: [VSCode Dir]\resources\app\out\vs\code\electron-sandbox\workbench\neondreams.js:164
// does it have content ? const tokenStyles = document.querySelector('.vscode-tokens-styles').innerText && document.querySelector('.vscode-tokens-styles').innerText !== '' && document.querySelector('.vscode-tokens-styles').innerText.includes(".mtk7");
You may also need to restart the vscode app to make the modification take effect.
Ty. Works for me.!!
Thanks all for the feedback and triage! I've been busy with a client work recently so haven't had a lot of time to devote to a new release, but I'll get it on asap
It was working fine yesterday but after the update the text is not glowing.
The solution of @tiruns is working fine at 9th december in vscode version 1.74. Thanks so much!
It looks like the ".vscode-tokens-styles" element may contain some default value instead of being empty, which triggers the theme to initialize too early.
A temporary workaround might be like: [VSCode Dir]\resources\app\out\vs\code\electron-sandbox\workbench\neondreams.js:164
// does it have content ? const tokenStyles = document.querySelector('.vscode-tokens-styles').innerText && document.querySelector('.vscode-tokens-styles').innerText !== '' && document.querySelector('.vscode-tokens-styles').innerText.includes(".mtk7");
You may also need to restart the vscode app to make the modification take effect.
works for me,thanks a lot!!!!
It looks like the ".vscode-tokens-styles" element may contain some default value instead of being empty, which triggers the theme to initialize too early.
A temporary workaround might be like: [VSCode Dir]\resources\app\out\vs\code\electron-sandbox\workbench\neondreams.js:164
// does it have content ? const tokenStyles = document.querySelector('.vscode-tokens-styles').innerText && document.querySelector('.vscode-tokens-styles').innerText !== '' && document.querySelector('.vscode-tokens-styles').innerText.includes(".mtk7");
You may also need to restart the vscode app to make the modification take effect.
Confirmed to work as well on 6.0.11-arch1-1
How can I make it work on Mac operating system?
~/.vscode/extensions/robbowen.synthwave-vscode-
as noted above, navigate to ~/.vscode/extensions/robbowen.synthwave-vscode-0.1.14/src/js/theme_template.js
and add the additional line of code.
Thanks all! As @tiruns said, the fix above will work temporarily but the .mtk classes are generated by VScode and they do sometimes change (this happened in the past and broke the colour scheme).
That said, the workaround pointed me straight to the cause of the issue, so massive thanks to @tiruns! 🙌
Last night I rewrote all of the bootstrap checks to be a bit more resilient - Before trying to replace the styles, the script now checks that all of the synthwave theme colours are present in the workbench dom styles. If the styles aren't there, it will try again the next time they update.
Anyhow, I did a local build of the fix and have been running it all day today. I haven't had any issues, so I'll try to tidy up the code a bit and push out a new version later this evening.
v0.1.15 is now available from the VS Code marketplace. 🎉🚀 As always with updates:
VScode has so many moving parts that rescuing this theme when it breaks is often way more difficult than it should be. Thanks for all the help in figuring this one out - I really appreciate it.
v0.1.15 is now available from the VS Code marketplace. 🎉🚀 As always with updates:
- Run the Disable Neon Dreams function from the command palette
- Uninstall the extension completely.
- Install the updated version of the extension (now v0.1.15)
- Run the Enable Neon Dreams function from the command palette.
VScode has so many moving parts that rescuing this theme when it breaks is often way more difficult than it should be. Thanks for all the help in figuring this one out - I really appreciate it.
Wow thank you so so much! I was so sad when I discovered my theme wasn't glowing and I was hoping it would. It's a favourite of mine, I can't code when it doesn't glow 🤣
It feels like characters and strings are dancing at the rhythm of my fingers. Super happy it's working now.
Now I can work again.
Thank you @robb0wen. It's working now.
Thanks all! I'll close this and keep my fingers crossed that the next VS code update doesn't change too much 😅
Hi, extension doesn't glow last days after update I follow steps: 1.Restart after enable neon dreams 2.Fix checksums![issue](https://user-images.githubusercontent.com/49201016/203515222-93c070cd-88ce-487b-baac-3df6415c56a2.png)