robb0wen / synthwave-vscode

Synthwave inspired colour theme for VS Code 🌅🕶

MIT License

5.19k stars 1.19k forks source link

Fix minimal compatibility for visual studio code version 1.94 (windows) #321

Closed horangelmillan closed 3 weeks ago

horangelmillan commented 1 month ago

This version fixes compatibility to enable "Neon Dreams" in VScode 1.94.

fix #320

Note: Only changes from the new version of VScode (1.94) on Windows were taken into account. EDIT*: functionality for older versions is still maintained.

Now enabling and disabling (admin mode) "Neon Dreams" does not throw an error.
Error messages when disabling "Neon Dreams" will now be displayed in a popup in the VScode interface.

EDIT*:

The functionality has been adjusted so that the extension can perform a more precise search for the necessary files, taking advantage of the features that node provides with respect to system accessibility.
Now the user will be able to provide the path of the "workbench.html" file manually, from the configuration interface or the "settings.json" as:

workbencHtmlPath property.

abregre commented 1 month ago

Fixes the error, but "Enable Neon Dreams" not working anymore, when I tried your extension.js locally

horangelmillan commented 1 month ago

Fixes the error, but "Enable Neon Dreams" not working anymore, when I tried your extension.js locally

HI @abregre, thanks for commenting,

just to be sure:

After replacing the "extension.js" file did you disable, update the extension host and then enable the "SynthWave '84" extension? If not, the changes were not applied before running the "Synthwave '84: Enable Neon Dreams" command.
Remember to run the "Synthwave '84: Enable Neon Dreams" command when VScode was started in administrator mode.

The last change made is in this branch from where the pull request "fix/compatibility_vsc_1.94" was made.

I look forward to your update and thanks for participating.

abregre commented 1 month ago

About the first bullet, i was not sure if I did, so I replicated it. About the second, I was able to run enable without administrator mode. Thanks, I followed someone elses recommendation and tried "Synthwave x Fluoromachine & epic animations"

robb0wen commented 3 weeks ago

327 Was merged and fixed the same issue, so I'm closing this. Thanks for taking a look though, as I said in the issue I really do appreciate it.