search

robb0wen / tornis

Tornis helps you watch and respond to changes in your browser's viewport 🌲
https://tornis.robbowen.digital
MIT License
1.58k stars 35 forks source link

Add Type Definitions #3

Closed taverasmisael closed 5 years ago

taverasmisael commented 5 years ago

Hello and thanks for the great work on Tornis! 👏

I would love if this project had Type Definitions in order to include it in projects using TypeScript, but I don't know your thoughts on the topic, so please let me know. I have a fork of the project and I would love to contribute with that if its something you would like and add value to the library of course.

robb0wen commented 5 years ago

I'm not all too familiar with TypeScript myself, but if the addition of type definitions could be done in a way that had no adverse effect on the standard module usage, I'd be open to it.

taverasmisael commented 5 years ago

Thanks, I'll be opening a PR with the TS Typings. Thanks!

robb0wen commented 5 years ago

Merged, and published to npm in v0.1.5