search

robbederks / downzip

NPM library to enable client-side code to stream potentially large files into a zipped download
MIT License
35 stars 12 forks source link

mapScriptUrl not called in the latest build #20

Closed keith-waters closed 1 year ago

keith-waters commented 3 years ago

When we swapped back over to your recently updated npm package, it wasn't working for us. Seem like the issue is mapScriptUrl never gets called by service-worker-loader.

I think another re-build of the package may solve it?

coleshaw commented 1 year ago

I ran into this -- I think it's because of a change in service-worker-loader in version 4.0.2? Pinning that to 4.0.0 seems to have helped us.

robbederks commented 1 year ago

Would appreciate a PR to either pin the version or fix it to work with the latest one!

coleshaw commented 1 year ago

Oh, whelp, upon further investigation should ignore my suggestion about pinning versions -- I think it was just something with my local node_modules :facepalm: Still run into the same issue.

robbederks commented 1 year ago

Should be fixed (see #28)