search

robbederks / downzip

NPM library to enable client-side code to stream potentially large files into a zipped download
MIT License
35 stars 12 forks source link

make sure serviceWorker is registered before running #7

Closed evliu closed 4 years ago

evliu commented 4 years ago

since this lib handles registering the service worker, should the service worker be manually checked or maybe async/await the construction of the DownZip object?

robbederks commented 4 years ago

The loading result is checked here: https://github.com/robbederks/downzip/blob/d1bfc82a9e7e9635f9065d0b122ab728523283dc/src/downzip.js#L17

Not sure how to best handle the not-loading, but I'd be happy to get a PR with a good implementation.

ricky11 commented 3 years ago

Can we use this module without service workers?