search

robbeofficial / spotifyripper

small ripper script for spotify (rips playlists to mp3 and includes ID3 tags and album covers)
659 stars 102 forks source link

eyeD3 -Q #29

Open ho1ger opened 9 years ago

ho1ger commented 9 years ago

In the code you're calling eyeD3 with -Q parameter. At least on my machine the -Q flag is not available and eyeD3 won't execute properly. Result: no album art, etc.

Remove -Q flag (no idea what this should do as I even didn't find it in the man page) and the code works.

cmd = "eyeD3" + \ " --add-image cover.jpg:FRONT_COVER" + \ " -t \"" + title + "\"" + \ " -a \"" + artist + "\"" + \ " -A \"" + album + "\"" + \ " -n " + str(num_track) + \ " -Y " + str(year) + \ " -Q " + \ " \"" + directory + mp3file + "\"" shell(cmd)

ghost commented 9 years ago

can u make a file with all the changes and make a pull request ? i'd like to have that feature

ho1ger commented 9 years ago

Never done this before but I'll look into this.

ghost commented 9 years ago

guess i have it allready

ho1ger commented 9 years ago

Also the other thing with the directory?