robbert-harms / MDT

Microstructure Diffusion Toolbox
GNU Lesser General Public License v3.0
50 stars 18 forks source link

Numpy errors #48

Open mrgrist opened 1 year ago

mrgrist commented 1 year ago

Hi there,

Am running numpy 1.24.0 and get the error 'AttributeError: module ‘numpy’ has no attribute ‘float’'

Seems like this will be a major problem going forwards? Can be solved by either replacing all calls with np.float64() or just remove np. and leave as foo = float().

Also problems with np.bool - needs to be replaced with bool

One could downgrade numpy version, but I think that won't be a long term solution?

Thoughts?

Update: After fixing all of the np.bool and np.float() calls, I still get a segmentation fault for Powell optimiser. However, no problems for LM.

robbert-harms commented 1 year ago

hi mrgrist,

Thanks for reporting the issue. This is a worry indeed, the world moves forward and MDT needs to keep up. Unfortunately I don't have much time to work on this. Could you perhaps create a pull request for all your changes?

Else it will take me some time to find time for this, unfortunately.

Best,

Robbert