robbert-vdh / nih-plug

Rust VST3 and CLAP plugin framework and plugins - because everything is better when you do it yourself
ISC License
1.81k stars 152 forks source link

Various ways to make Spectral Compressor crash in Reaper #133

Open jester-prawn opened 8 months ago

jester-prawn commented 8 months ago

I am on Windows 10 using Reaper patch 7.11 and Spectral Compressor from NIH plugs downloaded from Nightly a few days ago.

Opening a project with a large amount (~10+) of Spectral Compressor instances as a media item inside another project causes Reaper to crash. Attempting to delete an instance of Spectral Compressor from the Project Bay inconsistently causes Reaper to crash. It seems to be some instances do not cause the crash and some do.

p.s. can you plz make the ranges on the ratio sliders exponential rather than linear? A 1.1 ratio is half as much compression as a 1.2 ratio but the way the sliders are set up makes that the same as going from a 20.1 ratio to a 20.2 ratio, making it hard to control at lower compression levels.

p.p.s. Thank you for making this awesome plugin (and the other stuff I haven't checked out yet lol)

robbert-vdh commented 6 months ago

All of these are likely the same issue as #129 (and its various duplicates), which should now be fixed. If you have the time, could you check if any of these crashes still happen?