What's the difference with just using `<iframe ... />`?

For convenience. You you can wrap it up yourself and do the things this lib does yourself, sure. As with most things.

søn. 18. nov. 2018 kl. 14:40 skrev Koen Punt notifications@github.com:

I'm trying to understand why anyone would use this library, where they can simply use a plain .</p> <p>What does this library do, apart from wrapping the iframe in a PureComponent, and limiting support to only the defined properties?</p> <p>— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <a href="https://github.com/svenanders/react-iframe/issues/38">https://github.com/svenanders/react-iframe/issues/38</a>, or mute the thread <a href="https://github.com/notifications/unsubscribe-auth/ABfQp8f46V66JwxxfA0_Mt-EUf_Icf3Gks5uwWNUgaJpZM4Yn8dE">https://github.com/notifications/unsubscribe-auth/ABfQp8f46V66JwxxfA0_Mt-EUf_Icf3Gks5uwWNUgaJpZM4Yn8dE</a> .</p> <p>-- Mvh, Sven Anders Robbestad <a href="https://www.robbestad.com">https://www.robbestad.com</a> <a href="http://www.robbestad.com/">http://www.robbestad.com/</a></p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/koenpunt"><img src="https://avatars.githubusercontent.com/u/351038?v=4" />koenpunt</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>As with most things.</p> </blockquote> <p>Of course, but this is becoming absurdly trivial with React 16.6.0, by using <code>React.memo</code>;</p> <pre><code class="language-jsx">export const Iframe = React.memo((props) => React.createElement('iframe', props));</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/koenpunt"><img src="https://avatars.githubusercontent.com/u/351038?v=4" />koenpunt</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Also, if this is for convenience, why not forward all the props to the <code><iframe /></code>?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/polarathene"><img src="https://avatars.githubusercontent.com/u/5098581?v=4" />polarathene</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>@svenanders You didn't really answer this issue, why did you close it?</p> <p>This repo has alot of code in place to provide a package for this purpose. How relevant is it these days for users of React 16.6+ that could use the memo approach mentioned above?</p> <p>Why aren't props forwarded via spread? You have to provide updates when a user mentions a need for attribute support that could otherwise be handled. Perhaps there's a reason for that(or at least was in the past) due to issues users faced when using this package in ways different from most?</p> <blockquote> <p>For convenience. You you can wrap it up yourself and do the things this lib does yourself, sure. As with most things.</p> </blockquote> <p>The README for the repo doesn't explain what those "things" are. Some clarification would be great. I completely understand if there are special use cases or legacy reasons where this package would be a better choice.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/robbestad"><img src="https://avatars.githubusercontent.com/u/1560743?v=4" />robbestad</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>I gave a terse response. I’m not obligated to provide any at all, and to be honest, I regarded the original question as rather hostile. Forwarding the props would be pointless. The repo would be ‘const Iframe = props => <iframe {...props} />’ in that case. There is also not a lot of code in this repo. It’s just enough to provide type hints and it’s tested. This makes it easy to use and requires less testing in the code that consumes the lib.</p> <p>søn. 14. apr. 2019 kl. 07:06 skrev Brennan Kinney <notifications@github.com</p> <blockquote> <p>:</p> <p>@svenanders <a href="https://github.com/svenanders">https://github.com/svenanders</a> You didn't really answer this issue, why did you close it?</p> <p>This repo has alot of code in place to provide a package for this purpose. How relevant is it these days for users of React 16.6+ that could use the memo approach mentioned above?</p> <p>Why aren't props forwarded via spread? You have to provide updates when a user mentions a need for attribute support that could otherwise be handled. Perhaps there's a reason for that(or at least was in the past) due to issues users faced when using this package in ways different from most?</p> <p>For convenience. You you can wrap it up yourself and do the things this lib does yourself, sure. As with most things.</p> <p>The README for the repo doesn't explain what those "things" are. Some clarification would be great. I completely understand if there are special use cases or legacy reasons where this package would be a better choice.</p> <p>— You are receiving this because you were mentioned.</p> <p>Reply to this email directly, view it on GitHub <a href="https://github.com/svenanders/react-iframe/issues/38#issuecomment-482920298">https://github.com/svenanders/react-iframe/issues/38#issuecomment-482920298</a>, or mute the thread <a href="https://github.com/notifications/unsubscribe-auth/ABfQp6o8G80BTedkfuc_hKcHrGMIjcdVks5vgrdkgaJpZM4Yn8dE">https://github.com/notifications/unsubscribe-auth/ABfQp6o8G80BTedkfuc_hKcHrGMIjcdVks5vgrdkgaJpZM4Yn8dE</a> .</p> <p>-- Mvh, Sven Anders Robbestad <a href="http://www.robbestad.com">http://www.robbestad.com</a> <a href="http://twitter.com/#!/svenardocom">http://twitter.com/#!/svenardocom</a></p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/koenpunt"><img src="https://avatars.githubusercontent.com/u/351038?v=4" />koenpunt</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>I regarded the original question as rather hostile. </p> </blockquote> <p>The only reason why you would think so is because apparently it is true; this library doesn't provide any value over using a normal iframe.</p> <p>But my question initially was out of interest, I was wondering if I maybe missed a special case.</p> <p>Marketing this lib in that it has typescript types is not much added value either, given the fact that the html iframe tag already has types.</p> <p>I think in general this library is misleading for newcomers to the ecosystem, and it could do better in actually explaining what this library does, and how people could go without.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/koenpunt"><img src="https://avatars.githubusercontent.com/u/351038?v=4" />koenpunt</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>And your comment actually emphasizes the fact;</p> <blockquote> <p>Forwarding the props would be pointless. The repo would be ‘const Iframe = props => <iframe {...props} />’ in that case. </p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/robbestad"><img src="https://avatars.githubusercontent.com/u/1560743?v=4" />robbestad</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Right...</p> <p>søn. 14. apr. 2019 kl. 12:44 skrev Koen Punt <a href="mailto:notifications@github.com">notifications@github.com</a>:</p> <blockquote> <p>And your comment actually emphasizes the fact;</p> <p>Forwarding the props would be pointless. The repo would be ‘const Iframe = props => <iframe {...props} />’ in that case.</p> <p>— You are receiving this because you were mentioned.</p> <p>Reply to this email directly, view it on GitHub <a href="https://github.com/svenanders/react-iframe/issues/38#issuecomment-482946297">https://github.com/svenanders/react-iframe/issues/38#issuecomment-482946297</a>, or mute the thread <a href="https://github.com/notifications/unsubscribe-auth/ABfQpwbjbNKblwG2uqUafrbYSNMDVmZtks5vgwaagaJpZM4Yn8dE">https://github.com/notifications/unsubscribe-auth/ABfQpwbjbNKblwG2uqUafrbYSNMDVmZtks5vgwaagaJpZM4Yn8dE</a> .</p> <p>-- Mvh, Sven Anders Robbestad <a href="http://www.robbestad.com">http://www.robbestad.com</a> <a href="http://twitter.com/#!/svenardocom">http://twitter.com/#!/svenardocom</a></p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/robbestad"><img src="https://avatars.githubusercontent.com/u/1560743?v=4" />robbestad</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>I’m sorry you don’t understand the point of this repo.i advise you to avoid it and use something else. I further advise you to spend your time searching out other libs you don’t like or agree with and ask them to provide alternatives. </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

robbestad / react-iframe

What's the difference with just using `<iframe ... />`? #38