search

robbestad / react-iframe

Simple solution for using iframes in React
ISC License
436 stars 79 forks source link

README example vs typescript #64

Closed cdncat closed 2 years ago

cdncat commented 4 years ago

Hello! Thanks for creating this library :) Just wanted to note that display="initial" is part of the example in the README but in node_modules/react-iframe/types.d.ts, typescript will complain that the display attribute can only have "block" | "none" | "inline".

robbestad commented 2 years ago

Thanks for pointing this out. Added it to the types and also changed it the README to block