search

robbestad / react-iframe

Simple solution for using iframes in React
ISC License
436 stars 79 forks source link

Sandbox type does not allow multiple values #78

Closed nmoinvaz closed 2 years ago

nmoinvaz commented 4 years ago

The typescript definition for the sandbox property is a list of possible string values.

https://github.com/svenanders/react-iframe/blob/66a082995f77b1f0f44b3dcc77bcda7081719a42/src/types.d.ts#L26

I think it should just be a string. Currently that does not allow you to specify multiple values such as:

sandbox="allow-forms allow-scripts"

Maybe there is another way to specify it and keep typescript happy?

image

Sensiblemnd commented 3 years ago

sandbox Applies extra restrictions to the content in the frame. The value of the attribute can either be empty to apply all restrictions, or space-separated tokens to lift particular restrictions:

robbestad commented 2 years ago

It does not allow multiple values as a string. However, you can add it as an array. Example given in README.md and in the demo.