search

robbi5 / gomumblesoundboard

A Soundboard for the Mumble voice chat software written in Go.
17 stars 13 forks source link

404 Not Found #7

Open stonesword0 opened 3 years ago

stonesword0 commented 3 years ago

The website goes to a 404 page

[martini] listening on :3000 (development)

[martini] Completed 404 Not Found in 76.374µs

[martini] Completed 404 Not Found in 82.935µs

[martini] Completed 404 Not Found in 77.525µs

[martini] Completed 404 Not Found in 37.631µs

[martini] Completed 404 Not Found in 45.485µs

[martini] Completed 404 Not Found in 47.339µs

[martini] Completed 404 Not Found in 43.431µs

rralf commented 3 years ago

Same here.

jbruechert commented 3 years ago

The soundboard needs to be started from within the source directory, that helped in my case.

lnjX commented 3 years ago

Helpful error message might be nice, but I guess this can be closed.

rralf commented 3 years ago

Why printing an error message if this is a bug that can be fixed? I think it should rather be fixed than closed, but I'm not a Go guy...

jbruechert commented 3 years ago

Why printing an error message if this is a bug that can be fixed? I think it should rather be fixed than closed, but I'm not a Go guy...

Well technically it was never broken. You just need to start it in the correct working directory. I don't see how this could be fixed, but as @lnjX said, an error on the command line would be helpful to understand what is going on.

rralf commented 3 years ago

A chdir() to the correct directory would be a hacky fix, but would avoid printing an error message for a bug that can definitely be fixed. But I technically see no reason why cwd actually plays an role.

Take another example: If I'd like to start firefox, I don't want 'cd /usr/bin' every time I'd like to start it.

lnjX commented 3 years ago

Well okay that's actually right, it could just search for the files using a relative path from the binary. However a proper error message would be better than nothing for now.