search

robbi5 / kleineanfragen

Collecting kleine Anfragen from Parlamentsdokumentationssystemen for easy search- and linkability
https://kleineanfragen.de
MIT License
43 stars 9 forks source link

Revive Rubocop resp. Hound Tooling #122

Closed enricogenauck closed 5 years ago

enricogenauck commented 5 years ago

When contributing to a new project I personally welcome the existence of pointers for a common code- and quality style. Rubocop and Hound can be very useful to instil confidence for one's commit even before publishing.

So I'd like to fix rubocop in this instance but looking at the number of pilled up offences it could maybe become a more long-living pull request and a place for discussion about the requirement of specific rubocop rules.

But if there is currently no plan for rubocop please feel absolutely free to close this request. I can totally understand if there is currently not the energy or motivation to have this kind of "house-keeping" issues fixed or discussed.

enricogenauck commented 5 years ago

I just realised that Hound only checks the changes in the commit and not the overall code base. So I overestimated the impact of the fixed rubocop.yml. The problems will occur incrementally per pull-request and can then be tackled individually.

There is still the issue for people using rubocop on their development machine, but since it was kind of broken before I think it will not make a big difference.

So maybe it will not be such a long living pull request after all? 😄

robbi5 commented 5 years ago

this was one of the things on the (too long) to-do for this project. i've always wanted to get rubocop & hound in shape again, so thank you very much for tackling it :+1:

fixing the warnings with each pull-request sounds like a great idea :)