search

robbie-cahill / tunnelmole-client

Tunnelmole - Connect to local servers from anywhere
MIT License
1.29k stars 80 forks source link

Fixing eslint errors #3

Closed robbie-cahill closed 1 year ago

robbie-cahill commented 1 year ago

After adding eslint, there are a few errors based on the default recommended coding standards.

> tunnelmole@2.0.43 lint
> eslint . --ext .ts

/home/robbie/projects/tunnelmole-client/src/cli/dispatch-command.ts
   3:10  warning  'setApiKey' is defined but never used     @typescript-eslint/no-unused-vars
  10:54  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/robbie/projects/tunnelmole-client/src/message-handlers/forwarded-request.ts
  37:13  error    Do not use "@ts-ignore" because it alters compilation errors  @typescript-eslint/ban-ts-comment
  58:34  warning  Unexpected any. Specify a different type                      @typescript-eslint/no-explicit-any

/home/robbie/projects/tunnelmole-client/src/message-handlers/generic-message-handler.ts
  7:53   warning  'message' is defined but never used                      @typescript-eslint/no-unused-vars
  7:62   warning  Unexpected any. Specify a different type                 @typescript-eslint/no-explicit-any
  7:67   warning  'websocket' is defined but never used                    @typescript-eslint/no-unused-vars
  7:95   warning  'options' is defined but never used                      @typescript-eslint/no-unused-vars
  7:113  error    Unexpected empty async function 'genericMessageHandler'  @typescript-eslint/no-empty-function

/home/robbie/projects/tunnelmole-client/src/message-handlers/hostname-already-taken.ts
  4:61  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  4:66  warning  'websocket' is defined but never used     @typescript-eslint/no-unused-vars
  4:94  warning  'options' is defined but never used       @typescript-eslint/no-unused-vars

/home/robbie/projects/tunnelmole-client/src/message-handlers/invalid-subscription.ts
  5:82   warning  'websocket' is defined but never used  @typescript-eslint/no-unused-vars
  5:110  warning  'options' is defined but never used    @typescript-eslint/no-unused-vars

/home/robbie/projects/tunnelmole-client/src/messages/forwarded-request-message.ts
  7:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  8:11  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/robbie/projects/tunnelmole-client/src/messages/forwarded-response-message.ts
  8:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/robbie/projects/tunnelmole-client/src/tunnelmole.ts
  101:34  warning  'reject' is defined but never used  @typescript-eslint/no-unused-vars

/home/robbie/projects/tunnelmole-client/src/websocket/host-ip-websocket.ts
  5:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/robbie/projects/tunnelmole-client/test/integration/test-server/app.ts
  6:7  warning  'port' is assigned a value but never used  @typescript-eslint/no-unused-vars

/home/robbie/projects/tunnelmole-client/test/integration/tunnelmole.test.ts
  20:37  warning  'reject' is defined but never used                            @typescript-eslint/no-unused-vars
  73:13  error    Do not use "@ts-ignore" because it alters compilation errors  @typescript-eslint/ban-ts-comment

✖ 22 problems (3 errors, 19 warnings)

I'll get around to these at some point, but PRs are welcome.

robbie-cahill commented 1 year ago

Fixed a bunch, will create a new issue for the rest