robbie-cahill / tunnelmole-service

Give local web servers a public URL
GNU Affero General Public License v3.0
251 stars 39 forks source link

`moment` and `@types/body-parser` are missing from package dependencies #1

Closed reinhart1010 closed 8 months ago

reinhart1010 commented 1 year ago

Hi, I recently got this error while trying to build the server:

error TS2688: Cannot find type definition file for 'moment'.
  The file is in the program because:
    Entry point for implicit type library 'moment'

And also:

Could not find a declaration file for module 'body-parser'. '/home/shiftine/projects/tunnelmole-service/node_modules/.pnpm/body-parser@1.20.2/node_modules/body-parser/index.js' implicitly has an 'any' type.
  If the 'body-parser' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/body-parser'

These issues can be easily resolved by installing those missing packages. Maybe you should add it back to package.json.

robbie-cahill commented 8 months ago

Looks like the body-parser one resolved itself, I didn't get that error.

I added moment, which resolves the first issue.