robbiehanson / CocoaHTTPServer

A small, lightweight, embeddable HTTP server for Mac OS X or iOS applications
Other
5.59k stars 1.31k forks source link

CocoaLumberjack 2.x #141

Open tommeier opened 8 years ago

tommeier commented 8 years ago

Hi,

I was recently unable to use this dependency with the latest cocapods upgrade (0.37.2 -> 0.38.1).

screen shot 2015-07-24 at 4 38 23 pm

I'm using RoutingHTTPServer which has a dependency of CocoaHTTPServer.

TBH I'm wandering around in the dark on this project, I'm not sure why DDLogX is duplicated by the HTTPLogger? Is the real fix to change it to have a custom cocoalumberjack logger for the HTTP logging?

Anyway, I have no idea if this is the real fix or not, but this got it working again for me, would love to start the conversation of what the real fix would/should be as I wander in the darkness :)

tommeier commented 8 years ago

My particular issue was resolved by https://github.com/CocoaPods/CocoaPods/pull/3898. However, would still like to start the conversation on a conversion to 2.x cocoalumberjack, is this feasible? and would it remove a lot of code by having a custom logger setup instead of DDLog.h duplicated?

HardipAtWpost commented 8 years ago

:+1: Need this for a project we are working on that uses this library for unit tests.

wmtylerdavis commented 8 years ago

:+1: Yeah this seems relevant again with cocoapods 1.0.0.beta.3