search

robbiehanson / CocoaHTTPServer

A small, lightweight, embeddable HTTP server for Mac OS X or iOS applications
Other
5.61k stars 1.31k forks source link

WebSocket class has no prefix: causes conflict #29

Open j4johnfox opened 12 years ago

j4johnfox commented 12 years ago

Hi Robbie:

I've been happily using CocoaHTTPServer for some time now. Recently, for a client project, I integrated a realtime messaging framework from a third party that uses UnittWebSocketClient. This project also has a class named WebSocket:

http://code.google.com/p/unitt/source/browse/projects/iOS/UnittWebSocketClient/trunk/UnittWebSocketClient/WebSocket.h

I'm a bit surprised that neither that project's class nor the one you use has a prefix (e.g. RHWebSocket). I'm happy to make this change if you let me know what prefix you'd like to use.

If I've missed something, I'd love to know what.

Meanwhile, thanks again for releasing this incredibly useful code.

Best,

John

duhanebel commented 12 years ago

Same things for HTTPServer and Frank. Is it possible to add a prefix to the whole project? Like RH for example? It should be a matter of renaming everything and should take more than 15 minutes. I've done it on my branch but I'm struggling to keep up with updates this way.

lupinglade commented 11 years ago

Yes, all the classes need a prefix.