search

robbiehanson / XMPPFramework

An XMPP Framework in Objective-C for Mac and iOS
Other
5.91k stars 2.09k forks source link

Add Swift Package Manager support #1176

Closed karimhm closed 3 years ago

karimhm commented 4 years ago

Related to #1149

The following PRs need to be merged first before being able to add a Package.swift manifest to XMPPFramework

  • KissXML: #119
  • libidn-framework: #6
chrisballinger commented 4 years ago

This is also blocked on Xcode 12 because XMPPFramework includes resources, which requires SPM 5.3. See SE-0271 for more details.

https://github.com/robbiehanson/XMPPFramework/blob/9d625f5c12020a7edd5f533000404a249c8216f7/XMPPFramework.podspec#L37

karimhm commented 4 years ago

This is also blocked on Xcode 12 because XMPPFramework includes resources, which requires SPM 5.3. See SE-0271 for more details.

https://github.com/robbiehanson/XMPPFramework/blob/9d625f5c12020a7edd5f533000404a249c8216f7/XMPPFramework.podspec#L37

We could add Swift PM support but let the user to copy all assets needed by XMPPFramework, until Xcode 12 rolls out to production.

karimhm commented 4 years ago

@chrisballinger I believe it is possible to use XMPPFramework without Core Data extensions (but nothing will persist).

karimhm commented 4 years ago

@chrisballinger is it ok to migrate the Core Data object model from xcdatamodel bundle to code?

chrisballinger commented 4 years ago

@karimhm It would probably be better to leave the model definitions as-is to avoid breaking changes if possible. Really appreciate your work on the SPM support, it's been on my mind for a while and you did an awesome job getting all the pieces in place.