robbielyman / seamstress

seamstress is an art engine
GNU General Public License v3.0
129 stars 12 forks source link

fix lib UI #56

Closed p3r7 closed 1 year ago

p3r7 commented 1 year ago

lib/ui was broken on latest seamstress due to 2 reasons:

this PR solves #2 rather drastically, by removing the notion of window a UI element can draw itself to. the other approach would have been to replace screen.set & screen.reset w/ calls to _seamstress.screen_set.

that's specifically where i would need some guidance. i interpreted "discouraged" as deprecated in your comment:

breaking change: screen.set is removed; drawing to the params window in your scripts is discouraged.

robbielyman commented 1 year ago

Hmmm. I guess the only thing that gives me pause is that it would actually be very nice to use the UI library in the params menu. what about this: keep window out of the doc comments, but do keep it as a function param and just use _seamstress.screen_set?

p3r7 commented 1 year ago

alright, i'll switch to the _seamstress.screen_set implem.

p3r7 commented 1 year ago

done

robbielyman commented 1 year ago

thanks for revising! and for catching that changes were necessary!