`lib/lfo` calls unknown symbol `_menu`

robbielyman / seamstress

seamstress is an art engine

GNU General Public License v3.0

123 stars 12 forks source link

`lib/lfo` calls unknown symbol `_menu` #59

Closed p3r7 closed 1 year ago

p3r7 commented 1 year ago

lib/lfo calls _menu.rebuild_params() (here and here).

but in seamstress the _menu global is called paramsMenu (source).

i'd have been happy to fix but don't know which approach to take.

possible choices:

quick'n'dirty: replace _menu with paramsMenu in lib/lfo
🙈-patch: alias globally _menu to paramsMenu in seamstress.lua
follow norns conventions: replace all occurrences of paramsMenu with _menu

robbielyman commented 1 year ago

hmmmm. I like _menu = paramsMenu in seamstress.lua. I don't at the moment see room for other menus on the params window, but this seems the most reasonable for future changes.