robbiepaul / cloudconvert-laravel

A Laravel wrapper for the CloudConvert API
177 stars 34 forks source link

Laravel 5.1 Support #7

Closed tylerodonnell closed 9 years ago

tylerodonnell commented 9 years ago

Hi.

I'm trying to install this package to a Laravel 5.1 project. Unfortunately, Composer refuses to install the package.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for robbiep/cloudconvert-laravel 2.* -> satisfiable by robbiep/cloudconvert-laravel[v2.1].
    - Conclusion: remove laravel/framework v5.1.1
    - Conclusion: don't install laravel/framework v5.1.1
    - robbiep/cloudconvert-laravel v2.1 requires illuminate/filesystem 5.0.*@dev -> satisfiable by illuminate/filesystem[v5.0.0, v5.0.22, v5.0.25, v5.0.26, v5.0.28, v5.0.33, v5.0.4].
    - don't install illuminate/filesystem v5.0.0|don't install laravel/framework v5.1.1
    - don't install illuminate/filesystem v5.0.22|don't install laravel/framework v5.1.1
    - don't install illuminate/filesystem v5.0.25|don't install laravel/framework v5.1.1
    - don't install illuminate/filesystem v5.0.26|don't install laravel/framework v5.1.1
    - don't install illuminate/filesystem v5.0.28|don't install laravel/framework v5.1.1
    - don't install illuminate/filesystem v5.0.33|don't install laravel/framework v5.1.1
    - don't install illuminate/filesystem v5.0.4|don't install laravel/framework v5.1.1
    - Installation request for laravel/framework == 5.1.1.0 -> satisfiable by laravel/framework[v5.1.1].

I think it may be as simple as bumping your "illuminate/filesystem": "5.0.*@dev" line in composer.

Thanks!

IanCaunce commented 9 years ago

+1 Been testing it in Laravel 5.1 and it seems to be working smooth. The only addition would be to the documentation detailing how you declare providers in app.php.

It has changed from:

'providers' => array(
    ...
    'RobbieP\CloudConvertLaravel\CloudConvertLaravelServiceProvider'
)

To:

'providers' => array(
    ...
   RobbieP\CloudConvertLaravel\CloudConvertLaravelServiceProvider::class
)

But thats syntactical and both work fine.