This site needs some changes structurally, where it would warrant enough to be a rewrite, that meets my criteria on it needing improvement.
First, with regards to your HTML.
Class usage is great and what I expected.
Divs should be used for each section of content.
The body needs to hold the content of your HTML, some scripting frameworks and older browsers would not process this site properly as a result of this.
In general, inline styles are to be avoided. They do not give you the flexibility to change styling easily if you have multiple of them.
Readability is another big factor, the idea is whenever you write code, you are always writing it for others and want to make the best presentation possible.
Second, with regards to your CSS.
CSS file has a lot of repetition, use the corrections given as a guideline on how to approach this in the future.
To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.
robbiewolff
commented
6 years ago
Overall needs improvement.
This site needs some changes structurally, where it would warrant enough to be a rewrite, that meets my criteria on it needing improvement.
First, with regards to your HTML.
Class usage is great and what I expected.
Divs should be used for each section of content.
The body needs to hold the content of your HTML, some scripting frameworks and older browsers would not process this site properly as a result of this.
In general, inline styles are to be avoided. They do not give you the flexibility to change styling easily if you have multiple of them.
Readability is another big factor, the idea is whenever you write code, you are always writing it for others and want to make the best presentation possible.
Second, with regards to your CSS.
CSS file has a lot of repetition, use the corrections given as a guideline on how to approach this in the future.
To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.