search

robbrad / UKBinCollectionData

UK Council Bin Collection Data Parser Outputting Bin Data as a JSON
MIT License
136 stars 89 forks source link

Leeds City Council #44

Closed dp247 closed 2 years ago

dp247 commented 2 years ago

A friend pointed me towards this project a while ago and since I've started learning/using Python in a professional capacity, I thought I'd take a crack at adding my local council to the repo. Unfortunately, however, it seems that their website has Incapsula as a firewall, which returns a bot detection response (like the one here).

We do have an actual bin app though that's not made by the council and seems to be getting its data from Data Mill North via two CSV files. I thought about taking the same approach with this, but thought I'd ask permission first, since I know this project is more gained towards using BeautifulSoup.

I've started in my own repo using the CouncilClass like the other scripts - the only things that differ so far is the passed URL doesn't do anything, though I'll need to do something to handle PAON/postcode entry (either adding input prompts or passing as command line arguments somehow).

Is this a viable approach, or would I be better contributing by trying the outstanding requests?

dp247 commented 2 years ago

I thought I'd be able to add a label to this after I posted - it's a question, not an issue haha!

dp247 commented 2 years ago

Resolved by splitting LCC script and **kwargs into separate pull requests