robbrad / UKBinCollectionData

UK Council Bin Collection Data Parser Outputting Bin Data as a JSON
MIT License
140 stars 90 forks source link

Returning incorrect results #594

Closed sym0nd0 closed 9 months ago

sym0nd0 commented 9 months ago

Name of Council

Gedling Borough Council

Issue Information

All addresses are returning days/dates that don't match to the councils schedule.

Examples (random addresses from across the borough):

Steps to reproduce:

  1. Install in HACs
  2. Add integration in HA
  3. Add Service
  4. Enter street name in Location field (e.g. Haddon Road)
  5. Choose Gedling Borough Council from dropdown
  6. Submit
  7. Enter house number in house number field (e.g. 30)
  8. Submit and recieve success prompt
  9. Check entities have been created
  10. Check dates shown for entities against Councils pdfs

1 Chadburn results: image image image image

1 Chadburn council PDF: image image

Please let me know if you need me to provide anymore information, clarification on anything or if you require anything testing.

Verification

robbrad commented 9 months ago

@skelt0 / @roberthunt FYI

skelt0 commented 9 months ago

I'll take a look!

skelt0 commented 9 months ago

@sym0nd0 - The council only allow parsing of street names, so please put the street name into the house number field and try again.

The 'location' field, i believe, is how you will refer to the device location internally in Home Assistant, i.e. "Home".

Putting "Chadburn Road" into the house number field should give you the right results. Please can you test and let me know?

Appreciate there is some confusion, there was no field for 'street name only' for me to use so had to use house number. This is loosely documented in the wiki page for the council however thats mostly talking about how to use it on the command line

sym0nd0 commented 9 months ago

OMG, I knew it would be user error but never thought to try that. 🤦🏼‍♂️ I've just checked and it's working as expected.

Thanks for the quick help and your work to get this one sorted, @skelt0.

skelt0 commented 9 months ago

No worries @sym0nd0! Glad it's working now!