robbrad / UKBinCollectionData

UK Council Bin Collection Data Parser Outputting Bin Data as a JSON
MIT License
105 stars 73 forks source link

Add support for Birmingham City Council #698

Closed dannya closed 2 months ago

dannya commented 2 months ago

Fixes #570

Tested with:

collect_data.py -p "B5 7XE" -u 100070445256 BirminghamCityCouncil https://www.birmingham.gov.uk/xfp/form/619
collect_data.py -p "B27 6TF" -u 100070321799 BirminghamCityCouncil https://www.birmingham.gov.uk/xfp/form/619
collect_data.py -p "B3 1DW" -u 10033389698 BirminghamCityCouncil https://www.birmingham.gov.uk/xfp/form/619
collect_data.py -p "B13 9JP" -u "100070566109" BirminghamCityCouncil https://www.birmingham.gov.uk/xfp/form/619
collect_data.py -p "B13 8DS" -u "100070475114" BirminghamCityCouncil https://www.birmingham.gov.uk/xfp/form/619
robbrad commented 2 months ago

Hi @dannya great job here!

You also need to add an entry to the .feature file, and the input.json

See contributing.md

dannya commented 2 months ago

Hi @dannya great job here!

You also need to add an entry to the .feature file, and the input.json

See contributing.md

Updated.

robbrad commented 2 months ago

Looks like there is an error when it runs

See: https://github.com/robbrad/UKBinCollectionData/actions/runs/8987142195/job/24687925305#step:10:1

dannya commented 2 months ago

I'm actually getting a lot of test failures when I run poetry run pytest uk_bin_collection/tests/step_defs/ -n logical : 29 failed, 123 passed, 15 warnings in 79.44s (0:01:19) - are you seeing similar results?


Regardless, I've fixed the test runner issue for BirminghamCityCouncil in my latest commit (and also WelhatCouncil, which is existing code that I based my implementation on).

robbrad commented 2 months ago

Lot of the errors are due to councils changing

I'll merge your commit now

Thanks again