robbrad / UKBinCollectionData

UK Council Bin Collection Data Parser Outputting Bin Data as a JSON
MIT License
127 stars 82 forks source link

Selenium Test Videos #725

Closed OliverCullimore closed 4 months ago

OliverCullimore commented 4 months ago

Currently, it's hard/impossible to match the mp4 session recordings to councils.

Based on https://github.com/SeleniumHQ/docker-selenium/blob/trunk/README.md#video-recording-with-dynamic-file-name-based-on-metadata-in-tests it looks like we can just call options.set_capability('se:name', SESSION_NAME) within the create_webdriver() function to pass the council name to label the sessions and as a result the recordings with an identifiable name.

A random session ID will still be appended unless we pass SE_VIDEO_FILE_NAME_SUFFIX=false in the selenium ffmpeg container's environment variables which would result in there only being 1 mp4 file per council which gets overwritten each time the council is run which may actually be desirable?