robby1066 / keepposted-help

Documentation, Issue Tracker, and Repository of Knowledge For Keep Posted (www.keepposted.io) — A way to keep teams informed and connected without disrupting their focus.
https://www.keepposted.io
1 stars 0 forks source link

It's possible to hit the 'build' button with no clips defined #20

Closed robby1066 closed 3 years ago

robby1066 commented 3 years ago

Describe the bug

The logic for when the 'build' button is present checks to make sure that there are no clips present in a message that are missing a recorded video. The problem with that logic is that it returns true when there are no clips present at all.

Steps To Reproduce

  1. Go to compose a message
  2. Clear all the clips
  3. Save message
  4. Observe the "Ready to build" banner on the message edit page

Expected behavior

You shouldn't be able to attempt to build an empty message (which will throw an error anyway), and you should be prompted for how to correct the situation when there are no clips.

Screenshots

image

robby1066 commented 3 years ago

Fixed on Jan 25, 2021

image