robby1066 / keepposted-help

Documentation, Issue Tracker, and Repository of Knowledge For Keep Posted (www.keepposted.io) — A way to keep teams informed and connected without disrupting their focus.
https://www.keepposted.io
1 stars 0 forks source link

Be able to rearrange clips using keyboard navigation #42

Closed robby1066 closed 3 years ago

robby1066 commented 3 years ago

What's the problem you're hoping this new feature will solve?

If someone is not using a mouse, clips for a message cannot be re-ordered. That is a fairly common action, and it's a barrier to getting the full experience of the app.

Description of feature

This feature would allow people using a keyboard or other non-mouse device to move clips up or down in the sort order of a message on both the message create page, and the post-create edit screen.

Alternatives and workarounds

You have to use a mouse or trackpad to re-order clips.

Additional context

Github has a decent implementation of this on their issue listing pages that reveals itself when tabbing through, but doesn't clutter up the mouse-driven reordering experience.

See the arrow in the middle (focused) item in this screenshot for an example: image

robby1066 commented 3 years ago

See the Sortable documentation for some starting points on how to accomplish this.

robby1066 commented 3 years ago

Working on the placement of the arrows. This seems to make the most sense. When focused by the keyboard, both arrows (if available) take over the place of the draggable handle. Screenshot 2021-03-15 at 18 25 14

This image shows the basic placement, but in real life it would be an incorrect implementation because there should not be an 'up' arrow on the very first item, and should not be a 'down' arrow on the very last item.

robby1066 commented 3 years ago

Here's a writeup of the thought process behind how this issue was resolved.

robby1066 commented 3 years ago

This is implemented in development now. Needs to be deployed to production and then will do final testing and close the issue.

robby1066 commented 3 years ago

Tested and deployed on March 18