search

robby1066 / keepposted-help

Documentation, Issue Tracker, and Repository of Knowledge For Keep Posted (www.keepposted.io) — A way to keep teams informed and connected without disrupting their focus.
https://www.keepposted.io
1 stars 0 forks source link

The icon on invited users is displaying incorrectly #60

Closed robby1066 closed 3 years ago

robby1066 commented 3 years ago

Describe the bug

When inviting a new user to participate in a roundtable message, the icon (which shows the first letter of the person's first name) in the select list is rendered poorly. It should be a round icon, and there should be some margin between the icon and the name. As it displays now, it just looks like the first letter of the person's first name is repeated twice, and the first one is in another color with a halo around it.

Steps To Reproduce

  1. Go to /messages/roundtable
  2. Click on select specific people -> invite someone new
  3. Invite a test user
  4. See how the invited user's name displays in the select list.

Expected behavior

The icon shouldn't actually display at all, if it is to be consistent with how existing names in that list are displayed.

Screenshots

Screenshot 2021-06-15 at 13 51 17

robby1066 commented 3 years ago

Fixed and tested locally. The problem was that those entries can be constructed in two places, and the generated markup wasn't consistent. It was just a matter of removing the icon.

Will go out in the next deploy