search

robcalcroft / react-native-in-app-notification

:bell: Customisable in-app notification component for React Native
MIT License
270 stars 78 forks source link

add passProps to notificationOptions #39

Closed VitaliiK91 closed 4 years ago

VitaliiK91 commented 5 years ago

This pull request adds ability to pass arbitrary props to NotificationBody component. Props can be passed like:

const passProps = {
  type: 'error',
};

this.props.showNotification({
  title: 'You pressed it!',
  message: 'The notification has been triggered',
  onPress: () => Alert.alert('Alert', 'You clicked the notification!'),
  passProps,
});
VitaliiK91 commented 4 years ago

Hi @robcalcroft, any suggestions for this pull request? Any chances it can get merged? Thanks! 🙏

VitaliiK91 commented 4 years ago

@robcalcroft Thanks for reviewing, I addressed your comments. Let me know if it looks good. Best regards!

VitaliiK91 commented 4 years ago

@robcalcroft Thanks for reviewing, if everything looks good maybe it could be merged?

robcalcroft commented 4 years ago

Done 😄 sorry about the wait will release it on npm now