fix(package): react-native-swipe-gestures should be a dependency

robcalcroft / react-native-in-app-notification

:bell: Customisable in-app notification component for React Native

MIT License

270 stars 78 forks source link

fix(package): react-native-swipe-gestures should be a dependency #7

Closed timothystewart6 closed 7 years ago

timothystewart6 commented 7 years ago

Shouldn't this be a dependency? I understand that a peerDependency also works however shouldn't this just be a dependency since it is required to run? Are you listing it as a peer to avoid bundling issues? Thank you!

robcalcroft commented 7 years ago

I believe not listing it as a dependency was a conscious choice BUT I can't remember why haha. If everything is working ok in this PR with it listed as a dependency then I'm happy to merge

robcalcroft commented 7 years ago

Update: just looked at the blame for that file looks like it was introduced by another contributor and yes I agree it's in the wrong place 😄