search

robcarver17 / pysystemtrade

Systematic Trading in python
GNU General Public License v3.0
2.49k stars 798 forks source link

Update vol.py #1301

Closed meldinman closed 6 months ago

meldinman commented 7 months ago

can now forward and backfill in chained method, fillna(method="") is deprecated FutureWarning: Series.fillna with 'method' is deprecated and will raise in a future version. Use obj.ffill() or obj.bfill() instead.

robcarver17 commented 6 months ago

Chained python isn't very nice or clear to read, should be two seperate lines.

meldinman commented 6 months ago

Understood. I prefer to chain methods within similar tasks to reduce extra lines, but your call. I'll resubmit.